GtkPlacesSidebar: Fix an uninitialized variable in the error code path
authorKalev Lember <kalevlember@gmail.com>
Tue, 7 May 2013 11:41:21 +0000 (13:41 +0200)
committerKalev Lember <kalevlember@gmail.com>
Tue, 7 May 2013 12:01:54 +0000 (14:01 +0200)
Initialize it to NULL early so that we won't try to free an
uninitialized variable when handling an error.

gtk/gtkplacessidebar.c

index 310b6c79756e8c4c7c5b9a0b537effb830ccc388..87e0c5aca54c98e47f666047c89f78155233b7aa 100644 (file)
@@ -1606,6 +1606,7 @@ drag_motion_callback (GtkTreeView *tree_view,
 
        action = 0;
        drop_as_bookmarks = FALSE;
+       path = NULL;
 
        if (!sidebar->drag_data_received) {
                if (!get_drag_data (tree_view, context, time)) {
@@ -1613,7 +1614,6 @@ drag_motion_callback (GtkTreeView *tree_view,
                }
        }
 
-       path = NULL;
        res = compute_drop_position (tree_view, x, y, &path, &pos, sidebar);
 
        if (!res) {